From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Tue, 18 Jul 2023 18:16:38 +0000 (+0900)
Subject: udev: drop mostly unused Manager.pid
X-Git-Tag: v255-rc1~870^2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=79d2ecaf63ac4b3b9e35f29b070412152633ca24;p=thirdparty%2Fsystemd.git

udev: drop mostly unused Manager.pid

It is only used by the assertion in event_queue_insert().
We have similar check e.g. in sd-bus or sd-event, but udevd.c is not a
library code, hence such check is not necessary.
---

diff --git a/src/udev/udevd.c b/src/udev/udevd.c
index c93dc6905e4..214fc17861a 100644
--- a/src/udev/udevd.c
+++ b/src/udev/udevd.c
@@ -97,7 +97,6 @@ typedef struct Manager {
         Hashmap *workers;
         LIST_HEAD(Event, events);
         char *cgroup;
-        pid_t pid; /* the process that originally allocated the manager object */
         int log_level;
 
         UdevRules *rules;
@@ -776,9 +775,6 @@ static int event_queue_insert(Manager *manager, sd_device *dev) {
         assert(manager);
         assert(dev);
 
-        /* only one process can add events to the queue */
-        assert(manager->pid == getpid_cached());
-
         /* We only accepts devices received by device monitor. */
         r = sd_device_get_seqnum(dev, &seqnum);
         if (r < 0)
@@ -1532,8 +1528,6 @@ static int manager_new(Manager **ret, int fd_ctrl, int fd_uevent) {
 static int main_loop(Manager *manager) {
         int fd_worker, r;
 
-        manager->pid = getpid_cached();
-
         /* unnamed socket from workers to the main daemon */
         r = socketpair(AF_UNIX, SOCK_DGRAM|SOCK_CLOEXEC, 0, manager->worker_watch);
         if (r < 0)