From: Victor Stinner <vstinner@python.org>
Date: Thu, 19 Sep 2024 20:32:01 +0000 (+0200)
Subject: test_cext, test_cppext: enable /W4 warnings on Windows (#124253)
X-Git-Tag: v3.14.0a1~422
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7a2d77c903f29d7ea08b870b8e3fa2130f667a59;p=thirdparty%2FPython%2Fcpython.git

test_cext, test_cppext: enable /W4 warnings on Windows (#124253)

Add an explicit cast to (void*) and add Py_UNUSED() to fix some
warnings in extension.c.
---

diff --git a/Lib/test/test_cext/extension.c b/Lib/test/test_cext/extension.c
index eb23dbe20353..b76abe1d74c6 100644
--- a/Lib/test/test_cext/extension.c
+++ b/Lib/test/test_cext/extension.c
@@ -37,7 +37,13 @@ static PyMethodDef _testcext_methods[] = {
 
 
 static int
-_testcext_exec(PyObject *module)
+_testcext_exec(
+#ifdef __STDC_VERSION__
+    PyObject *module
+#else
+    PyObject *Py_UNUSED(module)
+#endif
+    )
 {
 #ifdef __STDC_VERSION__
     if (PyModule_AddIntMacro(module, __STDC_VERSION__) < 0) {
@@ -53,7 +59,7 @@ _testcext_exec(PyObject *module)
 }
 
 static PyModuleDef_Slot _testcext_slots[] = {
-    {Py_mod_exec, _testcext_exec},
+    {Py_mod_exec, (void*)_testcext_exec},
     {0, NULL}
 };
 
diff --git a/Lib/test/test_cext/setup.py b/Lib/test/test_cext/setup.py
index 19edc5e663c5..e97749b45ea6 100644
--- a/Lib/test/test_cext/setup.py
+++ b/Lib/test/test_cext/setup.py
@@ -31,6 +31,8 @@ if not support.MS_WINDOWS:
 else:
     # MSVC compiler flags
     CFLAGS = [
+        # Display warnings level 1 to 4
+        '/W4',
         # Treat all compiler warnings as compiler errors
         '/WX',
     ]
diff --git a/Lib/test/test_cppext/setup.py b/Lib/test/test_cppext/setup.py
index f1848f2fd42a..d97b238b8d14 100644
--- a/Lib/test/test_cppext/setup.py
+++ b/Lib/test/test_cppext/setup.py
@@ -22,6 +22,8 @@ if not support.MS_WINDOWS:
 else:
     # MSVC compiler flags
     CPPFLAGS = [
+        # Display warnings level 1 to 4
+        '/W4',
         # Treat all compiler warnings as compiler errors
         '/WX',
     ]