From: Noel Power Date: Tue, 13 Aug 2019 14:22:37 +0000 (+0100) Subject: s3/libsmd: clang: Fix some uninitialized value errors X-Git-Tag: talloc-2.3.1~272 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7a4da41c1efb62f5e528907a2e6c0aab766994e1;p=thirdparty%2Fsamba.git s3/libsmd: clang: Fix some uninitialized value errors Fixes: source3/libsmb/clilist.c:534:14: warning: 1st function call argument is an uninitialized value <--[clang] num_finfo = talloc_array_length(finfo); ^ source3/libsmb/clilist.c:1007:13: warning: The right operand of '<' is a garbage value <--[clang] for (i=0; i Reviewed-by: Ralph Boehme --- diff --git a/source3/libsmb/clilist.c b/source3/libsmb/clilist.c index 5cb1fce4338..58dac65f4c7 100644 --- a/source3/libsmb/clilist.c +++ b/source3/libsmb/clilist.c @@ -506,7 +506,7 @@ NTSTATUS cli_list_old(struct cli_state *cli, const char *mask, struct tevent_context *ev; struct tevent_req *req; NTSTATUS status = NT_STATUS_NO_MEMORY; - struct file_info *finfo; + struct file_info *finfo = NULL; size_t i, num_finfo; if (smbXcli_conn_has_async_calls(cli->conn)) { @@ -967,7 +967,7 @@ NTSTATUS cli_list(struct cli_state *cli, const char *mask, uint16_t attribute, struct tevent_req *req; NTSTATUS status = NT_STATUS_NO_MEMORY; struct file_info *finfo; - size_t i, num_finfo; + size_t i, num_finfo = 0; uint16_t info_level; if (smbXcli_conn_protocol(cli->conn) >= PROTOCOL_SMB2_02) {