From: Martin Panter <vadmium+py@gmail.com>
Date: Sat, 16 Jan 2016 05:18:47 +0000 (+0000)
Subject: Issue #14771: Redirect GDB's stdin to avoid messing the terminal settings
X-Git-Tag: v3.6.0a1~770^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7a5fe6d5d11ac1d86f49576d79506642f108edd5;p=thirdparty%2FPython%2Fcpython.git

Issue #14771: Redirect GDB's stdin to avoid messing the terminal settings

Otherwise, GDB seems to affect the terminal's foreground process group,
interfering with test_ioctl, which does not expect the foreground process to
change during the test. This change also solves the problem of the tests
being stopped in the shell if test_gdb is run twice in parallel.
---

diff --git a/Lib/test/test_gdb.py b/Lib/test/test_gdb.py
index 16fb389e7b9a..78fc55c2f204 100644
--- a/Lib/test/test_gdb.py
+++ b/Lib/test/test_gdb.py
@@ -75,6 +75,9 @@ def run_gdb(*args, **env_vars):
     if (gdb_major_version, gdb_minor_version) >= (7, 4):
         base_cmd += ('-iex', 'add-auto-load-safe-path ' + checkout_hook_path)
     proc = subprocess.Popen(base_cmd + args,
+                            # Redirect stdin to prevent GDB from messing with
+                            # the terminal settings
+                            stdin=subprocess.PIPE,
                             stdout=subprocess.PIPE,
                             stderr=subprocess.PIPE,
                             env=env)