From: Alexey Izbyshev Date: Fri, 9 Nov 2018 07:12:06 +0000 (+0300) Subject: bpo-35194: Fix a wrong constant in cp932 codec (GH-10420) X-Git-Tag: v3.8.0a1~538 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7a69cf47a9bbc95f95fd67c982bff121b2a903cb;p=thirdparty%2FPython%2Fcpython.git bpo-35194: Fix a wrong constant in cp932 codec (GH-10420) This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation. https://bugs.python.org/issue35194 --- diff --git a/Modules/cjkcodecs/_codecs_jp.c b/Modules/cjkcodecs/_codecs_jp.c index 2c7788a64581..3a332953b957 100644 --- a/Modules/cjkcodecs/_codecs_jp.c +++ b/Modules/cjkcodecs/_codecs_jp.c @@ -40,7 +40,7 @@ ENCODER(cp932) if (c == 0xf8f0) OUTBYTE1(0xa0); else - OUTBYTE1(c - 0xfef1 + 0xfd); + OUTBYTE1(c - 0xf8f1 + 0xfd); NEXT(1, 1); continue; }