From: Noel Power <noel.power@suse.com>
Date: Wed, 10 Jul 2019 10:22:49 +0000 (+0000)
Subject: libcli/smb: clang: Fix 'array access results in a null pointer deref'
X-Git-Tag: talloc-2.3.0~77
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7a86c99ccb6912effdbb0ffbdc5c66eccf8c1aa2;p=thirdparty%2Fsamba.git

libcli/smb: clang: Fix 'array access results in a null pointer deref'

Fixes:

smbXcli_base.c:1239:9: warning: Array access (via field 'pending') results in a null pointer dereference <--[clang]
                req = conn->pending[0];
                      ^

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/libcli/smb/smbXcli_base.c b/libcli/smb/smbXcli_base.c
index 2f5fac08128..37ae0a0e0e1 100644
--- a/libcli/smb/smbXcli_base.c
+++ b/libcli/smb/smbXcli_base.c
@@ -1229,7 +1229,8 @@ void smbXcli_conn_disconnect(struct smbXcli_conn *conn, NTSTATUS status)
 	 * conn->pending because that array changes in
 	 * smbXcli_req_unset_pending.
 	 */
-	while (talloc_array_length(conn->pending) > 0) {
+	while (conn->pending != NULL &&
+	       talloc_array_length(conn->pending) > 0) {
 		struct tevent_req *req;
 		struct smbXcli_req_state *state;
 		struct tevent_req **chain;