From: Greg Hudson <ghudson@mit.edu>
Date: Tue, 7 Aug 2012 04:54:46 +0000 (-0400)
Subject: Fix memory leak parsing name with default realm
X-Git-Tag: krb5-1.11-alpha1~339
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7abd3407cae8a68fc78884037c46405bb2fb91ec;p=thirdparty%2Fkrb5.git

Fix memory leak parsing name with default realm

After 74beb75bb07e3921d10c8eec05eacb1f393e5e44, allocate_princ()
allocates a one-byte realm field even if the principal doesn't have
one, so if we're replacing it with the default realm, we need to free
that.
---

diff --git a/src/lib/krb5/krb/parse.c b/src/lib/krb5/krb/parse.c
index c55381aefb..a696c711e1 100644
--- a/src/lib/krb5/krb/parse.c
+++ b/src/lib/krb5/krb/parse.c
@@ -208,6 +208,7 @@ krb5_parse_name_flags(krb5_context context, const char *name,
             ret = krb5_get_default_realm(context, &default_realm);
             if (ret)
                 goto cleanup;
+            krb5_free_data_contents(context, &princ->realm);
             princ->realm = string2data(default_realm);
         }
     } else if (no_realm) {