From: Eric Leblond <eric@regit.org>
Date: Wed, 29 Apr 2015 13:43:47 +0000 (+0200)
Subject: app-layer-smtp: fix SMTPTransactionFree function
X-Git-Tag: suricata-2.1beta4~36
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7b8184947ac6a32a2a23ff29042e716febf90829;p=thirdparty%2Fsuricata.git

app-layer-smtp: fix SMTPTransactionFree function

A typo was causing some freeing tasks not to be executed.
---

diff --git a/src/app-layer-smtp.c b/src/app-layer-smtp.c
index 90bc7d89fe..bc6459ab83 100644
--- a/src/app-layer-smtp.c
+++ b/src/app-layer-smtp.c
@@ -1126,8 +1126,9 @@ static void SMTPTransactionFree(SMTPTransaction *tx, SMTPState *state)
     /* Free list of MIME message recursively */
     MimeDecFreeEntity(tx->msg_head);
 
-    if (tx->decoder_events != NULL) {
+    if (tx->decoder_events != NULL)
         AppLayerDecoderEventsFreeEvents(&tx->decoder_events);
+
     if (tx->de_state != NULL)
         DetectEngineStateFree(tx->de_state);
 #if 0
@@ -1136,7 +1137,6 @@ static void SMTPTransactionFree(SMTPTransaction *tx, SMTPState *state)
         else
             smtp_state->events = 0;
 #endif
-    }
     SCFree(tx);
 }