From: Dong-hee Na <donghee.na@python.org>
Date: Thu, 14 Apr 2022 05:57:25 +0000 (+0900)
Subject: gh-90699: Remove usage of _Py_IDENTIFIER from bisect module. (GH-91522)
X-Git-Tag: v3.11.0b1~377
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7b87e8af0cb8df0d76e8ab18a9b12affb4526103;p=thirdparty%2FPython%2Fcpython.git

gh-90699: Remove usage of _Py_IDENTIFIER from bisect module. (GH-91522)
---

diff --git a/Modules/_bisectmodule.c b/Modules/_bisectmodule.c
index f884d94413c0..c54dc4979d00 100644
--- a/Modules/_bisectmodule.c
+++ b/Modules/_bisectmodule.c
@@ -4,7 +4,6 @@ Converted to C by Dmitry Vasiliev (dima at hlabs.spb.ru).
 */
 
 #define PY_SSIZE_T_CLEAN
-#define NEEDS_PY_IDENTIFIER
 #include "Python.h"
 
 /*[clinic input]
@@ -14,8 +13,6 @@ module _bisect
 
 #include "clinic/_bisectmodule.c.h"
 
-_Py_IDENTIFIER(insert);
-
 static inline Py_ssize_t
 internal_bisect_right(PyObject *list, PyObject *item, Py_ssize_t lo, Py_ssize_t hi,
                       PyObject* key)
@@ -132,7 +129,7 @@ _bisect_insort_right_impl(PyObject *module, PyObject *a, PyObject *x,
             return NULL;
     }
     else {
-        result = _PyObject_CallMethodId(a, &PyId_insert, "nO", index, x);
+        result = PyObject_CallMethod(a, "insert", "nO", index, x);
         if (result == NULL)
             return NULL;
         Py_DECREF(result);
@@ -258,7 +255,7 @@ _bisect_insort_left_impl(PyObject *module, PyObject *a, PyObject *x,
         if (PyList_Insert(a, index, x) < 0)
             return NULL;
     } else {
-        result = _PyObject_CallMethodId(a, &PyId_insert, "nO", index, x);
+        result = PyObject_CallMethod(a, "insert", "nO", index, x);
         if (result == NULL)
             return NULL;
         Py_DECREF(result);