From: likui <2218301630@qq.com>
Date: Wed, 19 Feb 2020 14:49:46 +0000 (+0800)
Subject: fix(compiler-core): should alias name in helperString (#743)
X-Git-Tag: v3.0.0-alpha.6~19
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7b987d9450fc7befcd0946a0d53991d27ed299ec;p=thirdparty%2Fvuejs%2Fcore.git

fix(compiler-core): should alias name in helperString (#743)

fix #740
---

diff --git a/packages/compiler-core/__tests__/transforms/vBind.spec.ts b/packages/compiler-core/__tests__/transforms/vBind.spec.ts
index 9aec71610f..b53160fd26 100644
--- a/packages/compiler-core/__tests__/transforms/vBind.spec.ts
+++ b/packages/compiler-core/__tests__/transforms/vBind.spec.ts
@@ -137,7 +137,7 @@ describe('compiler: transform v-bind', () => {
     expect(props.properties[0]).toMatchObject({
       key: {
         children: [
-          `${helperNameMap[CAMELIZE]}(`,
+          `_${helperNameMap[CAMELIZE]}(`,
           { content: `_ctx.foo` },
           `(`,
           { content: `_ctx.bar` },
diff --git a/packages/compiler-core/src/transform.ts b/packages/compiler-core/src/transform.ts
index bdaf918546..af62ba8675 100644
--- a/packages/compiler-core/src/transform.ts
+++ b/packages/compiler-core/src/transform.ts
@@ -161,10 +161,7 @@ export function createTransformContext(
       return name
     },
     helperString(name) {
-      return (
-        (context.prefixIdentifiers ? `` : `_`) +
-        helperNameMap[context.helper(name)]
-      )
+      return `_${helperNameMap[context.helper(name)]}`
     },
     replaceNode(node) {
       /* istanbul ignore if */
diff --git a/packages/compiler-core/src/transforms/transformElement.ts b/packages/compiler-core/src/transforms/transformElement.ts
index 7338db71e6..905268dee3 100644
--- a/packages/compiler-core/src/transforms/transformElement.ts
+++ b/packages/compiler-core/src/transforms/transformElement.ts
@@ -517,7 +517,6 @@ function buildDirectiveArgs(
   const dirArgs: ArrayExpression['elements'] = []
   const runtime = directiveImportMap.get(dir)
   if (runtime) {
-    context.helper(runtime)
     dirArgs.push(context.helperString(runtime))
   } else {
     // inject statement for resolving directive