From: Chao Yu <chao@kernel.org>
Date: Tue, 26 Mar 2024 11:28:45 +0000 (+0800)
Subject: f2fs: fix to wait on page writeback in __clone_blkaddrs()
X-Git-Tag: v5.10.219~164
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7b98f1493a5b012edc2b853270b82c4cf9c56c9a;p=thirdparty%2Fkernel%2Fstable.git

f2fs: fix to wait on page writeback in __clone_blkaddrs()

[ Upstream commit d3876e34e7e789e2cbdd782360fef2a777391082 ]

In below race condition, dst page may become writeback status
in __clone_blkaddrs(), it needs to wait writeback before update,
fix it.

Thread A				GC Thread
- f2fs_move_file_range
  - filemap_write_and_wait_range(dst)
					- gc_data_segment
					 - f2fs_down_write(dst)
					 - move_data_page
					  - set_page_writeback(dst_page)
					  - f2fs_submit_page_write
					 - f2fs_up_write(dst)
  - f2fs_down_write(dst)
  - __exchange_data_block
   - __clone_blkaddrs
    - f2fs_get_new_data_page
    - memcpy_page

Fixes: 0a2aa8fbb969 ("f2fs: refactor __exchange_data_block for speed up")
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 40e805014f719..678d72a870259 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1253,6 +1253,8 @@ static int __clone_blkaddrs(struct inode *src_inode, struct inode *dst_inode,
 				f2fs_put_page(psrc, 1);
 				return PTR_ERR(pdst);
 			}
+			f2fs_wait_on_page_writeback(pdst, DATA, true, true);
+
 			f2fs_copy_page(psrc, pdst);
 			set_page_dirty(pdst);
 			f2fs_put_page(pdst, 1);