From: Evan You <yyx990803@gmail.com>
Date: Wed, 31 Mar 2021 16:22:08 +0000 (-0400)
Subject: chore(sfc-playground): teardown preview update watcher
X-Git-Tag: v3.0.11~9
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7bc5fd9a04db4f4a335ca945ece9ed43271b1b52;p=thirdparty%2Fvuejs%2Fcore.git

chore(sfc-playground): teardown preview update watcher
---

diff --git a/packages/sfc-playground/src/output/Preview.vue b/packages/sfc-playground/src/output/Preview.vue
index 230025a5f4..637b618eb9 100644
--- a/packages/sfc-playground/src/output/Preview.vue
+++ b/packages/sfc-playground/src/output/Preview.vue
@@ -12,6 +12,7 @@
 <script setup lang="ts">
 import Message from '../Message.vue'
 import { ref, onMounted, onUnmounted, watchEffect } from 'vue'
+import type { WatchStopHandle } from 'vue'
 import srcdoc from './srcdoc.html?raw'
 import { PreviewProxy } from './PreviewProxy'
 import { MAIN_FILE, SANDBOX_VUE_URL } from '../sfcCompiler'
@@ -22,6 +23,7 @@ const runtimeError = ref()
 const runtimeWarning = ref()
 
 let proxy: PreviewProxy
+let updateHandle: WatchStopHandle
 
 async function updatePreview() {
   runtimeError.value = null
@@ -93,12 +95,13 @@ onMounted(() => {
 
   iframe.value.addEventListener('load', () => {
     proxy.handle_links()
-    watchEffect(updatePreview)
+    updateHandle = watchEffect(updatePreview)
   })
 })
 
 onUnmounted(() => {
   proxy.destroy()
+  updateHandle && updateHandle()
 })
 </script>