From: Stefan Metzmacher <metze@samba.org>
Date: Fri, 23 Oct 2020 09:54:29 +0000 (+0200)
Subject: librpc/dcesrv_core: assert that dcesrv_call_dispatch_local() never gets async.
X-Git-Tag: talloc-2.3.2~129
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7bd321e71b7f38994236d84795e08d3818b69dc1;p=thirdparty%2Fsamba.git

librpc/dcesrv_core: assert that dcesrv_call_dispatch_local() never gets async.

This is just not supported for now...

We would need a dcesrv_call_dispatch_local_send/recv in order to
support async calls.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14551

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
---

diff --git a/librpc/rpc/dcesrv_core.c b/librpc/rpc/dcesrv_core.c
index 783d75d5bfe..35d7947f438 100644
--- a/librpc/rpc/dcesrv_core.c
+++ b/librpc/rpc/dcesrv_core.c
@@ -3008,6 +3008,9 @@ _PUBLIC_ NTSTATUS dcesrv_call_dispatch_local(struct dcesrv_call_state *call)
 		return dcerpc_fault_to_nt_status(call->fault_code);
 	}
 
+	/* This can never go async for now! */
+	SMB_ASSERT(!(call->state_flags & DCESRV_CALL_STATE_FLAG_ASYNC));
+
 	push = ndr_push_init_ctx(call);
 	if (push == NULL) {
 		return NT_STATUS_NO_MEMORY;