From: Noel Power <noel.power@suse.com>
Date: Tue, 18 Jun 2019 10:19:09 +0000 (+0000)
Subject: lib/util: clang: Fix warning: Value stored to 'ret' is never read warning
X-Git-Tag: ldb-2.0.5~121
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7bddd6aefe3bd764560e5284f9a192797051bb2d;p=thirdparty%2Fsamba.git

lib/util: clang: Fix warning: Value stored to 'ret' is never read warning

Fixes:

lib/util/server_id_db.c:181:3: warning: Value stored to 'ret' is never read <--[clang]
                ret = tdb_store(tdb, key, talloc_tdb_data(ids), TDB_MODIFY);
                ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/lib/util/server_id_db.c b/lib/util/server_id_db.c
index e190f457526..bb61f316d29 100644
--- a/lib/util/server_id_db.c
+++ b/lib/util/server_id_db.c
@@ -184,7 +184,7 @@ int server_id_db_prune_name(struct server_id_db *db, const char *name,
 
 	tdb_chainunlock(tdb, key);
 
-	return 0;
+	return ret;
 }
 
 int server_id_db_remove(struct server_id_db *db, const char *name)