From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 26 Feb 2025 16:57:19 +0000 (+0100)
Subject: unit: initialize unit_file_preset field to valid value
X-Git-Tag: v258-rc1~966^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7cb7f8b8e430b6b9d3a6d8617d01703be0944701;p=thirdparty%2Fsystemd.git

unit: initialize unit_file_preset field to valid value

"-1" is not a valid enum value. Use a better one. All code using this
considers negative values error codes anyway, hence the old code was
just a weird way to write -EPERM. Let's clean this up.
---

diff --git a/src/core/unit.c b/src/core/unit.c
index 476c5332da9..21d57f73bcd 100644
--- a/src/core/unit.c
+++ b/src/core/unit.c
@@ -107,7 +107,7 @@ Unit* unit_new(Manager *m, size_t size) {
         u->type = _UNIT_TYPE_INVALID;
         u->default_dependencies = true;
         u->unit_file_state = _UNIT_FILE_STATE_INVALID;
-        u->unit_file_preset = -1;
+        u->unit_file_preset = _PRESET_ACTION_INVALID;
         u->on_failure_job_mode = JOB_REPLACE;
         u->on_success_job_mode = JOB_FAIL;
         u->job_timeout = USEC_INFINITY;