From: Benjamin Peterson <benjamin@python.org>
Date: Mon, 29 Apr 2013 13:08:14 +0000 (-0400)
Subject: raise an ImportError (rather than fatal) when __import__ is not found in __builtins__... 
X-Git-Tag: v3.3.2~51
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7d110042c5a2b27ffd0b3ae25dc7722f2f8bc5c5;p=thirdparty%2FPython%2Fcpython.git

raise an ImportError (rather than fatal) when __import__ is not found in __builtins__ (closes #17867)
---

diff --git a/Lib/test/test_import.py b/Lib/test/test_import.py
index 470a6d23927d..8be66a1893a4 100644
--- a/Lib/test/test_import.py
+++ b/Lib/test/test_import.py
@@ -324,6 +324,13 @@ class ImportTests(unittest.TestCase):
         except ImportError:
             self.fail("fromlist must allow bogus names")
 
+    @cpython_only
+    def test_delete_builtins_import(self):
+        args = ["-c", "del __builtins__.__import__; import os"]
+        popen = script_helper.spawn_python(*args)
+        stdout, stderr = popen.communicate()
+        self.assertIn(b"ImportError", stdout)
+
 
 @skip_if_dont_write_bytecode
 class FilePermissionTests(unittest.TestCase):
diff --git a/Misc/NEWS b/Misc/NEWS
index 6e6ee2ce78dc..eced97a6deb1 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -12,6 +12,8 @@ What's New in Python 3.3.2?
 Core and Builtins
 -----------------
 
+- Issue #17867: Raise an ImportError if __import__ is not found in __builtins__.
+
 - Issue #17857: Prevent build failures with pre-3.5.0 versions of sqlite3,
   such as was shipped with Centos 5 and Mac OS X 10.4.
 
diff --git a/Python/import.c b/Python/import.c
index 5fc2523b2685..26261e191488 100644
--- a/Python/import.c
+++ b/Python/import.c
@@ -1389,7 +1389,8 @@ PyImport_ImportModuleLevelObject(PyObject *name, PyObject *given_globals,
     if (builtins_import == NULL) {
         builtins_import = _PyDict_GetItemId(interp->builtins, &PyId___import__);
         if (builtins_import == NULL) {
-            Py_FatalError("__import__ missing");
+            PyErr_SetString(PyExc_ImportError, "__import__ not found");
+            goto error_with_unlock;
         }
     }
     Py_INCREF(builtins_import);