From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Mon, 18 Jan 2021 13:42:14 +0000 (+0000)
Subject: Fix issue in JSON bool evaluation
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7d36a6994d2ba9191e797ac2d62c4989f4b2d7fa;p=thirdparty%2Ffreeradius-server.git

Fix issue in JSON bool evaluation
---

diff --git a/src/lib/json/json.c b/src/lib/json/json.c
index ec6f7ebc8e4..550971eb815 100644
--- a/src/lib/json/json.c
+++ b/src/lib/json/json.c
@@ -153,8 +153,8 @@ int fr_json_object_to_value_box(TALLOC_CTX *ctx, fr_value_box_t *out, json_objec
 		break;
 
 	case json_type_boolean:
-		/* Don't cast to bool, else -Wbad-function-cast */
-		fr_value_box_shallow(out, (json_object_get_boolean(object) > 0), tainted);
+		/* Must be cast to bool for correct generic case selection */
+		fr_value_box_shallow(out, ((bool)(json_object_get_boolean(object) > 0)), tainted);
 		break;
 
 	case json_type_null: