From: Russell Bryant <russell@russellbryant.com>
Date: Fri, 11 May 2007 16:05:43 +0000 (+0000)
Subject: When MD5 authentication is not possible because there is no challenge present,
X-Git-Tag: 1.4.5~195
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7d478ee34245d34b88ece22127cad4eb722909ce;p=thirdparty%2Fasterisk.git

When MD5 authentication is not possible because there is no challenge present,
either because the Challenge action was never issued, or some other reason,
give a proper error message and return an error instead of claiming that the
user wasn't found.
(reported by jsmith on IRC)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63886 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/main/manager.c b/main/manager.c
index 383411fbe5..b7c37c9258 100644
--- a/main/manager.c
+++ b/main/manager.c
@@ -946,6 +946,11 @@ static int authenticate(struct mansession *s, const struct message *m)
 							ast_config_destroy(cfg);
 							return -1;
 						}
+					} else {
+						ast_log(LOG_DEBUG, "MD5 authentication is not possible.  challenge: '%s'\n", 
+							S_OR(s->challenge, ""));
+						ast_config_destroy(cfg);
+						return -1;
 					}
 				} else if (password && !strcmp(password, pass)) {
 					break;