From: Michael Adam <obnox@samba.org>
Date: Thu, 27 Mar 2008 17:01:43 +0000 (+0100)
Subject: regdb: use == 0 (instead of != -1) as indicator for success of dbwrap_trans_[delete... 
X-Git-Tag: samba-3.3.0pre1~3058
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7dcd0c1e539df9ff1768a9c878b6687b9e1bfeac;p=thirdparty%2Fsamba.git

regdb: use == 0 (instead of != -1) as indicator for success of dbwrap_trans_[delete|store]()

Michael
---

diff --git a/source/registry/reg_backend_db.c b/source/registry/reg_backend_db.c
index 44fb5caeb9e..ad170682955 100644
--- a/source/registry/reg_backend_db.c
+++ b/source/registry/reg_backend_db.c
@@ -986,10 +986,10 @@ static WERROR regdb_set_secdesc(const char *key,
 		/* assuming a delete */
 		tdb_ret = dbwrap_trans_delete(regdb,
 					      string_term_tdb_data(tdbkey));
-		if (tdb_ret == -1) {
-			err = ntstatus_to_werror(map_nt_error_from_unix(errno));
-		} else {
+		if (tdb_ret == 0) {
 			err = WERR_OK;
+		} else {
+			err = ntstatus_to_werror(map_nt_error_from_unix(errno));
 		}
 		goto done;
 	}
@@ -1003,7 +1003,7 @@ static WERROR regdb_set_secdesc(const char *key,
 
 	tdb_ret = dbwrap_trans_store(regdb, string_term_tdb_data(tdbkey),
 				     tdbdata, 0);
-	if (tdb_ret == -1) {
+	if (tdb_ret != 0) {
 		err = ntstatus_to_werror(map_nt_error_from_unix(errno));
 		goto done;
 	}