From: Michal Simek <michal.simek@amd.com>
Date: Wed, 29 Apr 2026 06:22:08 +0000 (+0200)
Subject: fdt: check fdt_pack() return value in fdtdec_apply_bloblist_dtos()
X-Git-Tag: v2026.07-rc2~27
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7dd93524eacfec8512700056fcb54a4ba5c8fd8b;p=thirdparty%2Fu-boot.git

fdt: check fdt_pack() return value in fdtdec_apply_bloblist_dtos()

The fdt_pack() function can return an error code, but its return value
was not being checked. Add proper error handling to propagate any
failure.

Also fix typo in comment: "Shink" -> "Shrink".

Addresses-Coverity-ID: CID 645839: Error handling issues (CHECKED_RETURN)
Signed-off-by: Michal Simek <michal.simek@amd.com>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Raymond Mao <raymondmaoca@gmail.com>
---

diff --git a/lib/fdtdec.c b/lib/fdtdec.c
index c6e13b6abef..2d66860f6ed 100644
--- a/lib/fdtdec.c
+++ b/lib/fdtdec.c
@@ -1781,8 +1781,11 @@ static int fdtdec_apply_bloblist_dtos(void)
 	if (ret)
 		return ret;
 
-	/* Shink the blob to the actual FDT size */
-	fdt_pack(live_fdt);
+	/* Shrink the blob to the actual FDT size */
+	ret = fdt_pack(live_fdt);
+	if (ret)
+		return ret;
+
 	return bloblist_resize(BLOBLISTT_CONTROL_FDT, fdt_totalsize(live_fdt));
 }