From: Jelle van der Waa <jelle@vdwaa.nl>
Date: Fri, 14 Nov 2025 12:56:22 +0000 (+0100)
Subject: userdb: prefer using SD_JSON_BUILD_PAIR_* over SD_JSON_BUILD_PAIR(
X-Git-Tag: v259-rc1~55^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7e5d718046546eb0ca32d39063b362660fb249d4;p=thirdparty%2Fsystemd.git

userdb: prefer using SD_JSON_BUILD_PAIR_* over SD_JSON_BUILD_PAIR(

No functional change, just refactoring.
---

diff --git a/src/userdb/userdbctl.c b/src/userdb/userdbctl.c
index 823b68e7d94..c0df726fe49 100644
--- a/src/userdb/userdbctl.c
+++ b/src/userdb/userdbctl.c
@@ -918,8 +918,8 @@ static int show_membership(const char *user, const char *group, Table *table) {
 
                 r = sd_json_buildo(
                                 &v,
-                                SD_JSON_BUILD_PAIR("user", SD_JSON_BUILD_STRING(user)),
-                                SD_JSON_BUILD_PAIR("group", SD_JSON_BUILD_STRING(group)));
+                                SD_JSON_BUILD_PAIR_STRING("user", user),
+                                SD_JSON_BUILD_PAIR_STRING("group", group));
                 if (r < 0)
                         return log_error_errno(r, "Failed to build JSON object: %m");
 
diff --git a/src/userdb/userwork.c b/src/userdb/userwork.c
index fc698e841da..ae927bb5287 100644
--- a/src/userdb/userwork.c
+++ b/src/userdb/userwork.c
@@ -119,8 +119,8 @@ static int build_user_json(sd_varlink *link, UserRecord *ur, sd_json_variant **r
 
         return sd_json_buildo(
                         ret,
-                        SD_JSON_BUILD_PAIR("record", SD_JSON_BUILD_VARIANT(v)),
-                        SD_JSON_BUILD_PAIR("incomplete", SD_JSON_BUILD_BOOLEAN(stripped->incomplete)));
+                        SD_JSON_BUILD_PAIR_VARIANT("record", v),
+                        SD_JSON_BUILD_PAIR_BOOLEAN("incomplete", stripped->incomplete));
 }
 
 static int userdb_flags_from_service(sd_varlink *link, const char *service, UserDBFlags *ret) {
@@ -280,8 +280,8 @@ static int build_group_json(sd_varlink *link, GroupRecord *gr, sd_json_variant *
 
         return sd_json_buildo(
                         ret,
-                        SD_JSON_BUILD_PAIR("record", SD_JSON_BUILD_VARIANT(v)),
-                        SD_JSON_BUILD_PAIR("incomplete", SD_JSON_BUILD_BOOLEAN(stripped->incomplete)));
+                        SD_JSON_BUILD_PAIR_VARIANT("record", v),
+                        SD_JSON_BUILD_PAIR_BOOLEAN("incomplete", stripped->incomplete));
 }
 
 static int vl_method_get_group_record(sd_varlink *link, sd_json_variant *parameters, sd_varlink_method_flags_t flags, void *userdata) {
@@ -437,8 +437,8 @@ static int vl_method_get_memberships(sd_varlink *link, sd_json_variant *paramete
 
                         r = sd_varlink_notifybo(
                                         link,
-                                        SD_JSON_BUILD_PAIR("userName", SD_JSON_BUILD_STRING(last_user_name)),
-                                        SD_JSON_BUILD_PAIR("groupName", SD_JSON_BUILD_STRING(last_group_name)));
+                                        SD_JSON_BUILD_PAIR_STRING("userName", last_user_name),
+                                        SD_JSON_BUILD_PAIR_STRING("groupName", last_group_name));
                         if (r < 0)
                                 return r;
                 }
@@ -456,8 +456,8 @@ static int vl_method_get_memberships(sd_varlink *link, sd_json_variant *paramete
 
         return sd_varlink_replybo(
                         link,
-                        SD_JSON_BUILD_PAIR("userName", SD_JSON_BUILD_STRING(last_user_name)),
-                        SD_JSON_BUILD_PAIR("groupName", SD_JSON_BUILD_STRING(last_group_name)));
+                        SD_JSON_BUILD_PAIR_STRING("userName", last_user_name),
+                        SD_JSON_BUILD_PAIR_STRING("groupName", last_group_name));
 }
 
 static int process_connection(sd_varlink_server *server, int _fd) {