From: Evan You Date: Mon, 9 Sep 2019 20:03:34 +0000 (-0400) Subject: chore: todos X-Git-Tag: v3.0.0-alpha.0~799 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7e70acf9c2e1823ad071f1760f8c8505f6173e9d;p=thirdparty%2Fvuejs%2Fcore.git chore: todos --- diff --git a/packages/runtime-core/src/createRenderer.ts b/packages/runtime-core/src/createRenderer.ts index d76d400d60..a582faeb1c 100644 --- a/packages/runtime-core/src/createRenderer.ts +++ b/packages/runtime-core/src/createRenderer.ts @@ -623,7 +623,7 @@ export function createRenderer< ) if (suspense.deps > 0) { // still pending. - // patch the fallback tree. + // TODO patch the fallback tree. } else { suspense.resolve() } @@ -677,9 +677,7 @@ export function createRenderer< ) // now check if we have encountered any async deps if (suspense.deps > 0) { - // yes: mount the fallback tree. - // Each time an async dep resolves, it pings the boundary - // and causes a re-entry. + // TODO mount the fallback tree. console.log('fallback') } else { suspense.resolve() @@ -742,6 +740,7 @@ export function createRenderer< setupRenderEffect(instance, n2, container, anchor, isSVG) } else if ( shouldUpdateComponent(n1, n2, optimized) || + // TODO use context suspense (instance.provides.suspense && !(instance.provides.suspense as any).isResolved) ) { @@ -793,6 +792,7 @@ export function createRenderer< // setup() is async. This component relies on async logic to be resolved // before proceeding if (instance.asyncDep) { + // TODO use context suspense const suspense = (instance as any).provides.suspense if (!suspense) { throw new Error('Async component without a suspense boundary!')