From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 12 May 2021 11:45:01 +0000 (+0200)
Subject: terminal-util: add debug logging for when TTY ioctls fail
X-Git-Tag: v249-rc1~194^2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7eaee902862433ffa45f0e73046226830ac33ab1;p=thirdparty%2Fsystemd.git

terminal-util: add debug logging for when TTY ioctls fail
---

diff --git a/src/basic/terminal-util.c b/src/basic/terminal-util.c
index fafdaaa090e..91c404892ea 100644
--- a/src/basic/terminal-util.c
+++ b/src/basic/terminal-util.c
@@ -245,17 +245,20 @@ int reset_terminal_fd(int fd, bool switch_to_text) {
          * interfere with that. */
 
         /* Disable exclusive mode, just in case */
-        (void) ioctl(fd, TIOCNXCL);
+        if (ioctl(fd, TIOCNXCL) < 0)
+                log_debug_errno(errno, "TIOCNXCL ioctl failed on TTY, ignoring: %m");
 
         /* Switch to text mode */
         if (switch_to_text)
-                (void) ioctl(fd, KDSETMODE, KD_TEXT);
+                if (ioctl(fd, KDSETMODE, KD_TEXT) < 0)
+                        log_debug_errno(errno, "KDSETMODE ioctl for switching to text mode failed on TTY, ignoring: %m");
+
 
         /* Set default keyboard mode */
         (void) vt_reset_keyboard(fd);
 
         if (tcgetattr(fd, &termios) < 0) {
-                r = -errno;
+                r = log_debug_errno(errno, "Failed to get terminal parameters: %m");
                 goto finish;
         }