From: Tomas Mraz <tomas@openssl.org>
Date: Wed, 7 Jun 2023 11:22:19 +0000 (+0200)
Subject: Coverity 1531836: Check return value of CRYPTO_atomic_add()
X-Git-Tag: openssl-3.2.0-alpha1~673
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7efc073dd7ddaed732c35e84efc865463db7ffbc;p=thirdparty%2Fopenssl.git

Coverity 1531836: Check return value of CRYPTO_atomic_add()
---

diff --git a/providers/implementations/rands/drbg.c b/providers/implementations/rands/drbg.c
index 4690d73cca9..7a4854f0d7c 100644
--- a/providers/implementations/rands/drbg.c
+++ b/providers/implementations/rands/drbg.c
@@ -335,8 +335,9 @@ static size_t prov_drbg_get_nonce(PROV_DRBG *drbg, unsigned char **pout,
     /* Use the built in nonce source plus some of our specifics */
     memset(&data, 0, sizeof(data));
     data.drbg = drbg;
-    CRYPTO_atomic_add(&dngbl->rand_nonce_count, 1, &data.count,
-                      dngbl->rand_nonce_lock);
+    if (!CRYPTO_atomic_add(&dngbl->rand_nonce_count, 1, &data.count,
+                      dngbl->rand_nonce_lock))
+        return 0;
     return ossl_prov_get_nonce(drbg->provctx, pout, min_len, max_len,
                                &data, sizeof(data));
 }