From: Mark Andrews <marka@isc.org>
Date: Mon, 30 Jan 2023 13:57:57 +0000 (+1100)
Subject: Call OSSL_STORE_INFO_free on error path
X-Git-Tag: v9.19.11~89^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7f12c0884f6fc87ada262a19b870d9fafced2f07;p=thirdparty%2Fbind9.git

Call OSSL_STORE_INFO_free on error path
---

diff --git a/lib/dns/openssl_link.c b/lib/dns/openssl_link.c
index 3ec31330dae..017e5d6977c 100644
--- a/lib/dns/openssl_link.c
+++ b/lib/dns/openssl_link.c
@@ -301,19 +301,23 @@ dst__openssl_fromlabel_provider(int key_base_id, const char *engine,
 		switch (OSSL_STORE_INFO_get_type(info)) {
 		case OSSL_STORE_INFO_PKEY:
 			if (*ppriv != NULL) {
+				OSSL_STORE_INFO_free(info);
 				DST_RET(DST_R_INVALIDPRIVATEKEY);
 			}
 			*ppriv = OSSL_STORE_INFO_get1_PKEY(info);
 			if (EVP_PKEY_get_base_id(*ppriv) != key_base_id) {
+				OSSL_STORE_INFO_free(info);
 				DST_RET(DST_R_BADKEYTYPE);
 			}
 			break;
 		case OSSL_STORE_INFO_PUBKEY:
 			if (*ppub != NULL) {
+				OSSL_STORE_INFO_free(info);
 				DST_RET(DST_R_INVALIDPUBLICKEY);
 			}
 			*ppub = OSSL_STORE_INFO_get1_PUBKEY(info);
 			if (EVP_PKEY_get_base_id(*ppub) != key_base_id) {
+				OSSL_STORE_INFO_free(info);
 				DST_RET(DST_R_BADKEYTYPE);
 			}
 			break;