From: Mark Andrews <marka@isc.org>
Date: Thu, 16 Sep 2021 00:30:37 +0000 (+1000)
Subject: Specifying sig-signing-type causes named to fail
X-Git-Tag: v9.17.19~35^2~3
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=7f5f7b2d7b9007e19aee9334d9a6e8063608d7fa;p=thirdparty%2Fbind9.git

Specifying sig-signing-type causes named to fail

the range check error was being applied unconditionally
---

diff --git a/lib/bind9/check.c b/lib/bind9/check.c
index 01ad26803e3..5cc360624e8 100644
--- a/lib/bind9/check.c
+++ b/lib/bind9/check.c
@@ -3237,8 +3237,8 @@ check_zoneconf(const cfg_obj_t *zconfig, const cfg_obj_t *voptions,
 					    "sig-signing-type: %u out of "
 					    "range [%u..%u]",
 					    type, 0xff00U, 0xffffU);
+				result = ISC_R_FAILURE;
 			}
-			result = ISC_R_FAILURE;
 		}
 
 		obj = NULL;