From: Gary Lockyer Date: Tue, 15 Dec 2020 21:56:22 +0000 (+1300) Subject: pep8 tidy up config X-Git-Tag: samba-4.14.0rc1~249 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8004cf7a4aff8f5a8615bc68c0e61d5bd5de039b;p=thirdparty%2Fsamba.git pep8 tidy up config Enable the following warnings: E126: continuation line over-indented for hanging indent E131: continuation line unaligned for hanging indent E203: whitespace before ':' E221: multiple spaces before operator E501: line too long E722: do not use bare 'except' These were originally chosen so that as much of the existing samba code passed. With the intention of integrating PEP8 checking into build process. But the PEP8 output does not integrate into the known fail mechanism, so this approach was abandoned. setup.cfg is the default PEP8 config file having these exceptions enabled means that new code can be added with those issues. Also tools like pyls (python language server) use setup.cfg. Disable the following warnings: E402: module level import not at top of file Samba has a significant amount of code setting sys.path.insert(0, "bin/python") W503: Line break before binary operator We need to have a preference, and PEP8 expresses a weak preference for disabling 503 Signed-off-by: Gary Lockyer Reviewed-by: Andrew Bartlett Reviewed-by: Douglas Bagnall Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Thu Dec 17 00:54:51 UTC 2020 on sn-devel-184 --- diff --git a/setup.cfg b/setup.cfg index 0752e0acbb5..6c3d32cbc92 100644 --- a/setup.cfg +++ b/setup.cfg @@ -1,12 +1,8 @@ [pycodestyle] # refer to: https://pep8.readthedocs.io/en/1.4.6/intro.html#error-codes -# E126: continuation line over-indented for hanging indent -# E131: continuation line unaligned for hanging indent -# E203: whitespace before ':' -# E221: multiple spaces before operator -# E501: line too long -# E722: do not use bare 'except' -ignore = E126,E131,E203,E221,E501,E722 -exclude = bin,heimdal,wscript,third_party,wafsamba,tdb,.ycm_extra_conf.py,examples,python/samba/subunit/run.py,autobuild.py +# E402: module level import not at top of file +# W503: line break before binary operator +# +ignore = E402,W503 show-source = true statistics = true