From: Aram Sargsyan <aram@isc.org>
Date: Thu, 2 May 2024 08:33:51 +0000 (+0000)
Subject: Fix a bug in expireheader() call arguments order
X-Git-Tag: v9.19.24~3^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8052848d50fa3b072079cd58860b2fa0d7fe278d;p=thirdparty%2Fbind9.git

Fix a bug in expireheader() call arguments order

The expireheader() call in the expire_ttl_headers() function
is erroneous as it passes the 'nlocktypep' and 'tlocktypep'
arguments in a wrong order, which then causes an assertion
failure.

Fix the order of the arguments so it corresponds to the function's
prototype.
---

diff --git a/lib/dns/qpcache.c b/lib/dns/qpcache.c
index 2c3eaed3988..1a03944bb7c 100644
--- a/lib/dns/qpcache.c
+++ b/lib/dns/qpcache.c
@@ -4415,7 +4415,7 @@ expire_ttl_headers(qpcache_t *qpdb, unsigned int locknum,
 			return;
 		}
 
-		expireheader(header, tlocktypep, nlocktypep,
+		expireheader(header, nlocktypep, tlocktypep,
 			     dns_expire_ttl DNS__DB_FLARG_PASS);
 	}
 }