From: Andreas Schneider Date: Mon, 21 Jan 2019 12:16:56 +0000 (+0100) Subject: s3:rpc_client: Use C99 inititializer in dcerpc_samr_chgpasswd_user() X-Git-Tag: ldb-2.0.5~161 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=80b6ad51f9a029e0b315dabc852ce548bc76a21f;p=thirdparty%2Fsamba.git s3:rpc_client: Use C99 inititializer in dcerpc_samr_chgpasswd_user() This also cleans up after using them. Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett --- diff --git a/source3/rpc_client/cli_samr.c b/source3/rpc_client/cli_samr.c index e2bf08de4a0..7764e1a8540 100644 --- a/source3/rpc_client/cli_samr.c +++ b/source3/rpc_client/cli_samr.c @@ -41,15 +41,10 @@ NTSTATUS dcerpc_samr_chgpasswd_user(struct dcerpc_binding_handle *h, NTSTATUS status; struct samr_Password hash1, hash2, hash3, hash4, hash5, hash6; - uchar old_nt_hash[16]; - uchar old_lm_hash[16]; - uchar new_nt_hash[16]; - uchar new_lm_hash[16]; - - ZERO_STRUCT(old_nt_hash); - ZERO_STRUCT(old_lm_hash); - ZERO_STRUCT(new_nt_hash); - ZERO_STRUCT(new_lm_hash); + uint8_t old_nt_hash[16] = {0}; + uint8_t old_lm_hash[16] = {0}; + uint8_t new_nt_hash[16] = {0}; + uint8_t new_lm_hash[16] = {0}; DEBUG(10,("rpccli_samr_chgpasswd_user\n")); @@ -81,6 +76,11 @@ NTSTATUS dcerpc_samr_chgpasswd_user(struct dcerpc_binding_handle *h, &hash6, presult); + ZERO_ARRAY(old_nt_hash); + ZERO_ARRAY(old_lm_hash); + ZERO_ARRAY(new_nt_hash); + ZERO_ARRAY(new_lm_hash); + return status; } diff --git a/source3/wscript_build b/source3/wscript_build index b61fc3cc95f..7d44071225e 100644 --- a/source3/wscript_build +++ b/source3/wscript_build @@ -1062,7 +1062,7 @@ bld.SAMBA3_SUBSYSTEM('INIT_NETLOGON', bld.SAMBA3_SUBSYSTEM('INIT_SAMR', source='rpc_client/init_samr.c', - deps='samba-util') + deps='samba-util GNUTLS_HELPERS') bld.SAMBA3_SUBSYSTEM('LIBLSA', source='lib/lsa.c')