From: Georg Brandl <georg@python.org>
Date: Thu, 29 Sep 2005 20:16:07 +0000 (+0000)
Subject: bug [ 1296004 ] MemoryError in httplib
X-Git-Tag: v2.5a0~1331
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=80ba8e85490515c293959a4196cbd99b1b3819a2;p=thirdparty%2FPython%2Fcpython.git

bug [ 1296004 ] MemoryError in httplib
---

diff --git a/Lib/httplib.py b/Lib/httplib.py
index e017cdfcd519..5c82edd89697 100644
--- a/Lib/httplib.py
+++ b/Lib/httplib.py
@@ -153,6 +153,9 @@ HTTP_VERSION_NOT_SUPPORTED = 505
 INSUFFICIENT_STORAGE = 507
 NOT_EXTENDED = 510
 
+# maximal amount of data to read at one time in _safe_read
+MAXAMOUNT = 1048576
+
 class HTTPMessage(mimetools.Message):
 
     def addheader(self, key, value):
@@ -541,14 +544,14 @@ class HTTPResponse:
         reading. If the bytes are truly not available (due to EOF), then the
         IncompleteRead exception can be used to detect the problem.
         """
-        s = ''
+        s = []
         while amt > 0:
-            chunk = self.fp.read(amt)
+            chunk = self.fp.read(min(amt, MAXAMOUNT))
             if not chunk:
                 raise IncompleteRead(s)
-            s += chunk
+            s.append(chunk)
             amt -= len(chunk)
-        return s
+        return ''.join(s)
 
     def getheader(self, name, default=None):
         if self.msg is None:
diff --git a/Misc/NEWS b/Misc/NEWS
index 9703f695ca74..ec70b951e642 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -242,6 +242,9 @@ Extension Modules
 Library
 -------
 
+- Bug #1296004: httplib.py: Limit maximal amount of data read from the
+  socket to avoid a MemoryError on Windows.
+
 - Patch #1166948: locale.py: Prefer LC_ALL, LC_CTYPE and LANG over LANGUAGE
   to get the correct encoding.