From: JINMEI Tatuya <jinmei@isc.org>
Date: Mon, 1 Apr 2013 22:09:59 +0000 (-0700)
Subject: [2833] added test cases where 'allowed' is false
X-Git-Tag: bind10-1.1.0beta1-release~11^2~11
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=80d60b6b5653d581c6cfe1fb05a4128eacc4e1d6;p=thirdparty%2Fkea.git

[2833] added test cases where 'allowed' is false
---

diff --git a/src/lib/datasrc/tests/cache_config_unittest.cc b/src/lib/datasrc/tests/cache_config_unittest.cc
index 43cc6672e6..00959f1cae 100644
--- a/src/lib/datasrc/tests/cache_config_unittest.cc
+++ b/src/lib/datasrc/tests/cache_config_unittest.cc
@@ -99,6 +99,11 @@ TEST_F(CacheConfigTest, badConstructMasterFiles) {
                              *Element::fromJSON("{\"cache-enable\": false,"
                                                 " \"params\": {}}"), true),
                  CacheConfigError);
+    // cache enabled but not "allowed"
+    EXPECT_THROW(CacheConfig("MasterFiles", 0,
+                             *Element::fromJSON("{\"cache-enable\": false,"
+                                                " \"params\": {}}"), false),
+                 CacheConfigError);
     // type error for cache-enable
     EXPECT_THROW(CacheConfig("MasterFiles", 0,
                              *Element::fromJSON("{\"cache-enable\": 1,"
@@ -162,8 +167,13 @@ TEST_F(CacheConfigTest, constructWithMock) {
     const ConstElementPtr config_elem_disabled(
         Element::fromJSON("{\"cache-enable\": false,"
                           " \"cache-zones\": [\"example.com\"]}"));
-    EXPECT_TRUE(CacheConfig("mock", &mock_client_, *config_elem_disabled, true).
-                getZoneConfig().empty());
+    EXPECT_FALSE(CacheConfig("mock", &mock_client_, *config_elem_disabled,
+                             true).isEnabled());
+    // enabled but not "allowed".  same effect.
+    EXPECT_FALSE(CacheConfig("mock", &mock_client_,
+                             *Element::fromJSON("{\"cache-enable\": true,"
+                                                " \"cache-zones\": []}"),
+                             false).isEnabled());
 }
 
 TEST_F(CacheConfigTest, badConstructWithMock) {