From: James Coglan <james@neighbourhood.ie>
Date: Tue, 28 May 2024 15:01:56 +0000 (+0100)
Subject: resolved: tests for dns_answer_has_dname_for_cname()
X-Git-Tag: v257-rc1~841^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8105438cd227f6687f0e39d28384ac359565dd65;p=thirdparty%2Fsystemd.git

resolved: tests for dns_answer_has_dname_for_cname()
---

diff --git a/src/resolve/test-dns-answer.c b/src/resolve/test-dns-answer.c
index a40586f0d8f..dc5e4a12236 100644
--- a/src/resolve/test-dns-answer.c
+++ b/src/resolve/test-dns-answer.c
@@ -821,6 +821,88 @@ TEST(dns_answer_move_by_key_multi_leave_source) {
         ASSERT_EQ(dns_answer_size(target), 2u);
 }
 
+/* ================================================================
+ * dns_answer_has_dname_for_cname()
+ * ================================================================ */
+
+TEST(dns_answer_has_dname_for_cname_pass) {
+        _cleanup_(dns_answer_unrefp) DnsAnswer *answer = dns_answer_new(0);
+        _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *cname = NULL, *dname = NULL;
+
+        ASSERT_NOT_NULL(answer);
+
+        dname = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_DNAME, "example.com");
+        ASSERT_NOT_NULL(dname);
+        dname->dname.name = strdup("v2.example.com");
+        dns_answer_add(answer, dname, 1, DNS_ANSWER_CACHEABLE, NULL);
+
+        cname = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_CNAME, "www.example.com");
+        ASSERT_NOT_NULL(cname);
+        cname->cname.name = strdup("www.v2.example.com");
+        ASSERT_TRUE(dns_answer_has_dname_for_cname(answer, cname));
+}
+
+TEST(dns_answer_has_dname_for_cname_no_dname) {
+        _cleanup_(dns_answer_unrefp) DnsAnswer *answer = dns_answer_new(0);
+        _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *cname = NULL;
+
+        ASSERT_NOT_NULL(answer);
+
+        cname = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_CNAME, "www.example.com");
+        ASSERT_NOT_NULL(cname);
+        cname->cname.name = strdup("www.v2.example.com");
+        ASSERT_FALSE(dns_answer_has_dname_for_cname(answer, cname));
+}
+
+TEST(dns_answer_has_dname_for_cname_no_match_old_suffix) {
+        _cleanup_(dns_answer_unrefp) DnsAnswer *answer = dns_answer_new(0);
+        _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *cname = NULL, *dname = NULL;
+
+        dname = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_DNAME, "example.com");
+        ASSERT_NOT_NULL(dname);
+        dname->dname.name = strdup("v2.examples.com");
+        dns_answer_add(answer, dname, 1, DNS_ANSWER_CACHEABLE, NULL);
+
+        cname = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_CNAME, "www.example.com");
+        ASSERT_NOT_NULL(cname);
+        cname->cname.name = strdup("www.v2.example.com");
+        ASSERT_FALSE(dns_answer_has_dname_for_cname(answer, cname));
+}
+
+TEST(dns_answer_has_dname_for_cname_no_match_new_suffix) {
+        _cleanup_(dns_answer_unrefp) DnsAnswer *answer = dns_answer_new(0);
+        _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *cname = NULL, *dname = NULL;
+
+        ASSERT_NOT_NULL(answer);
+
+        dname = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_DNAME, "example.com");
+        ASSERT_NOT_NULL(dname);
+        dname->dname.name = strdup("v2.example.com");
+        dns_answer_add(answer, dname, 1, DNS_ANSWER_CACHEABLE, NULL);
+
+        cname = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_CNAME, "www.example.com");
+        ASSERT_NOT_NULL(cname);
+        cname->cname.name = strdup("www.v3.example.com");
+        ASSERT_FALSE(dns_answer_has_dname_for_cname(answer, cname));
+}
+
+TEST(dns_answer_has_dname_for_cname_not_cname) {
+        _cleanup_(dns_answer_unrefp) DnsAnswer *answer = dns_answer_new(0);
+        _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *cname = NULL, *dname = NULL;
+
+        ASSERT_NOT_NULL(answer);
+
+        dname = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_DNAME, "example.com");
+        ASSERT_NOT_NULL(dname);
+        dname->dname.name = strdup("v2.example.com");
+        dns_answer_add(answer, dname, 1, DNS_ANSWER_CACHEABLE, NULL);
+
+        cname = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com");
+        ASSERT_NOT_NULL(cname);
+        cname->a.in_addr.s_addr = htobe32(0xc0a8017f);
+        ASSERT_FALSE(dns_answer_has_dname_for_cname(answer, cname));
+}
+
 /* ================================================================
  * dns_answer_dump()
  * ================================================================ */