From: Zanie Blue <contact@zanie.dev>
Date: Mon, 30 Dec 2024 08:55:14 +0000 (-0600)
Subject: gh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 requirements (#128322)
X-Git-Tag: v3.14.0a4~171
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=81376fef76a53fb79893bfa9c9db18d97c228fbe;p=thirdparty%2FPython%2Fcpython.git

gh-128321: Set LIBS instead of LDFLAGS when checking sqlite3 requirements (#128322)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
---

diff --git a/Misc/NEWS.d/next/Build/2024-12-28-21-05-19.gh-issue-128321.0UvbXw.rst b/Misc/NEWS.d/next/Build/2024-12-28-21-05-19.gh-issue-128321.0UvbXw.rst
new file mode 100644
index 000000000000..ed72cc8ab144
--- /dev/null
+++ b/Misc/NEWS.d/next/Build/2024-12-28-21-05-19.gh-issue-128321.0UvbXw.rst
@@ -0,0 +1,3 @@
+Set ``LIBS`` instead of ``LDFLAGS`` when checking if :mod:`sqlite3` library
+functions are available. This fixes the ordering of linked libraries during
+checks, which was incorrect when using a statically linked ``libsqlite3``.
diff --git a/configure b/configure
index 299eff6bc3bf..3d2c60213db5 100755
--- a/configure
+++ b/configure
@@ -15434,7 +15434,7 @@ save_LIBS=$LIBS
 
 
   CPPFLAGS="$CPPFLAGS $LIBSQLITE3_CFLAGS"
-  LDFLAGS="$LIBSQLITE3_LIBS $LDFLAGS"
+  LIBS="$LIBSQLITE3_LIBS $LIBS"
 
   ac_fn_c_check_header_compile "$LINENO" "sqlite3.h" "ac_cv_header_sqlite3_h" "$ac_includes_default"
 if test "x$ac_cv_header_sqlite3_h" = xyes
diff --git a/configure.ac b/configure.ac
index badb19d55895..ee034e5a9621 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4220,7 +4220,7 @@ WITH_SAVE_ENV([
 dnl bpo-45774/GH-29507: The CPP check in AC_CHECK_HEADER can fail on FreeBSD,
 dnl hence CPPFLAGS instead of CFLAGS.
   CPPFLAGS="$CPPFLAGS $LIBSQLITE3_CFLAGS"
-  LDFLAGS="$LIBSQLITE3_LIBS $LDFLAGS"
+  LIBS="$LIBSQLITE3_LIBS $LIBS"
 
   AC_CHECK_HEADER([sqlite3.h], [
     have_sqlite3=yes