From: Eric Wong <e@80x24.org>
Date: Sun, 26 Oct 2025 00:04:12 +0000 (+0000)
Subject: rproxy: remove line context on backend disconnects
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=815328c75d67e75784e17f6bd5d9dc9a22465037;p=thirdparty%2Fpublic-inbox.git

rproxy: remove line context on backend disconnects

It's worthless, especially when using `die' instead of `croak'.
In any case, there's not much we can do if upstream decides to
shut down a partially written stream for whatever reason (e.g.
OOM) so stop giving line information about it.  Adding request
information may be helpful at some point, but that's for another
time.
---

diff --git a/lib/PublicInbox/H1ReqRes.pm b/lib/PublicInbox/H1ReqRes.pm
index ad99a5c77..7b28f4d23 100644
--- a/lib/PublicInbox/H1ReqRes.pm
+++ b/lib/PublicInbox/H1ReqRes.pm
@@ -103,9 +103,9 @@ sub read_err ($$;$) {
 				scalar(@{$self->{wbuf}});
 		$self->{res_left} = $len if defined $len;
 	} elsif (defined $len) {
-		die "W: upstream terminated while reading response ($len)";
+		die "W: upstream terminated while reading response ($len)\n";
 	} else {
-		die 'W: upstream terminated while reading response';
+		die "W: upstream terminated while reading response\n";
 	}
 	undef;
 }