From: Ondřej Surý <ondrej@sury.org>
Date: Thu, 4 Mar 2021 09:43:00 +0000 (+0100)
Subject: Use int type to store result from isc_commandline_parse()
X-Git-Tag: v9.17.11~18^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8153729d3a59eafa7e02068f239d9a999d302b99;p=thirdparty%2Fbind9.git

Use int type to store result from isc_commandline_parse()

The C standard actually doesn't define char as signed or unsigned, and
it could be either according to underlying architecture.  It turns out
that while it's usually signed type, it isn't on arm64 where it's
unsigned.

isc_commandline_parse() return int, just use that instead of the char.
---

diff --git a/bin/tools/named-journalprint.c b/bin/tools/named-journalprint.c
index 37cc0ff2054..cea855e4c67 100644
--- a/bin/tools/named-journalprint.c
+++ b/bin/tools/named-journalprint.c
@@ -67,7 +67,7 @@ main(int argc, char **argv) {
 	isc_result_t result;
 	isc_log_t *lctx = NULL;
 	uint32_t flags = 0U;
-	char ch;
+	int ch;
 	bool downgrade = false;
 	bool upgrade = false;