From: Julian Seward <jseward@acm.org>
Date: Mon, 17 Mar 2008 16:23:54 +0000 (+0000)
Subject: Kludgily fix a regression caused by the recent DATASYMS merge, which
X-Git-Tag: svn/VALGRIND_3_4_0~848
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=81663bc4b755902f857b5c3fc9565b70d6e5225a;p=thirdparty%2Fvalgrind.git

Kludgily fix a regression caused by the recent DATASYMS merge, which
caused V to hang when running Amarok in KDE 3.5.X.



git-svn-id: svn://svn.valgrind.org/valgrind/trunk@7723
---

diff --git a/coregrind/m_debuginfo/debuginfo.c b/coregrind/m_debuginfo/debuginfo.c
index a37aaa67ef..b1a3e817e4 100644
--- a/coregrind/m_debuginfo/debuginfo.c
+++ b/coregrind/m_debuginfo/debuginfo.c
@@ -520,6 +520,35 @@ void VG_(di_notify_mmap)( Addr a, Bool allow_SkFileV )
    if (debug)
       VG_(printf)("di_notify_mmap-2: %s\n", filename);
 
+   /* XXXX begin KLUDGE */
+   /* Skip filenames in /dev/.  Don't even bother to try opening them.
+      Why?
+
+      Suppose the client opens and then mmaps the file specified by
+      'filename' and puts some kind of lock on it, so nobody else can
+      open it.  If we now try to open it to peer at the ELF header,
+      the system can hang, because the VG_(open) call blocks.
+      Precisely this happed when running Amarok, which opened and then
+      mmap'd /dev/snd/pcmC0D0c.
+
+      A clean(er) solution is to open the file with VKI_O_NONBLOCK, so
+      that if it is locked, we simply fail immediately and don't hang
+      the whole system.  But "man 2 open" gives only a sketchy
+      description of the resulting file semantics.  So for the
+      meantime, just skip files in /dev/ as (1) they are likely to be
+      subject to wierd-ass locking stuff, and (2) they won't contain
+      useful debug info anyway.
+
+      But that's a kludge; in principle the same problem could occur
+      with *any* file.
+   */
+   if (0 == VG_(strncmp)(filename, "/dev/", 5)) {
+      if (debug)
+         VG_(printf)("di_notify_mmap-2: skipping %s\n", filename);
+      return;
+   }
+   /* XXXX end KLUDGE */
+
    /* Peer at the first few bytes of the file, to see if it is an ELF
       object file. */
    VG_(memset)(buf1k, 0, sizeof(buf1k));