From: Susant Sahani <ssahani@gmail.com>
Date: Thu, 9 May 2019 18:24:29 +0000 (+0530)
Subject: networkd: Log error if LLDP fails to start/stop
X-Git-Tag: v243-rc1~462
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8185ca6c0a6165bf8c10dfed01f5fd68a3915b17;p=thirdparty%2Fsystemd.git

networkd: Log error if LLDP fails to start/stop

Now LLDP does not log anything why it failed which
is hard to debug. Let's just add some logs.

https://github.com/systemd/systemd/issues/10881
---

diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
index 4db9f3f980f..f13fcb7b6e6 100644
--- a/src/network/networkd-link.c
+++ b/src/network/networkd-link.c
@@ -3027,10 +3027,14 @@ static int link_update_lldp(Link *link) {
                 r = sd_lldp_start(link->lldp);
                 if (r > 0)
                         log_link_debug(link, "Started LLDP.");
+                else
+                        log_link_warning_errno(link, r, "Failed to start LLDP: %m");
         } else {
                 r = sd_lldp_stop(link->lldp);
                 if (r > 0)
                         log_link_debug(link, "Stopped LLDP.");
+                else
+                        log_link_warning_errno(link, r, "Failed to stop LLDP: %m");
         }
 
         return r;