From: Julian Seward <jseward@acm.org>
Date: Tue, 3 May 2005 09:09:27 +0000 (+0000)
Subject: Generate better code for CmpNEZ64(Or64(x,y)), a common idiom resulting
X-Git-Tag: svn/VALGRIND_3_0_1^2~176
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8190870a02f49a8d2f336eddd316e268385fb4ba;p=thirdparty%2Fvalgrind.git

Generate better code for CmpNEZ64(Or64(x,y)), a common idiom resulting
from memchecking of FP code.



git-svn-id: svn://svn.valgrind.org/vex/trunk@1158
---

diff --git a/VEX/priv/host-x86/isel.c b/VEX/priv/host-x86/isel.c
index 0cfe5924e4..33a1a8d7d6 100644
--- a/VEX/priv/host-x86/isel.c
+++ b/VEX/priv/host-x86/isel.c
@@ -1560,7 +1560,7 @@ static X86CondCode iselCondCode_wrk ( ISelEnv* env, IRExpr* e )
       if (matchIRExpr(&mi, p_CmpNEZ32_And32, e)) {
          HReg    r0   = iselIntExpr_R(env, mi.bindee[0]);
          X86RMI* rmi1 = iselIntExpr_RMI(env, mi.bindee[1]);
-         HReg tmp = newVRegI(env);
+         HReg    tmp  = newVRegI(env);
          addInstr(env, mk_iMOVsd_RR(r0, tmp));
          addInstr(env, X86Instr_Alu32R(Xalu_AND,rmi1,tmp));
          return Xcc_NZ;
@@ -1575,12 +1575,13 @@ static X86CondCode iselCondCode_wrk ( ISelEnv* env, IRExpr* e )
       if (matchIRExpr(&mi, p_CmpNEZ32_Or32, e)) {
          HReg    r0   = iselIntExpr_R(env, mi.bindee[0]);
          X86RMI* rmi1 = iselIntExpr_RMI(env, mi.bindee[1]);
-         HReg tmp = newVRegI(env);
+         HReg    tmp  = newVRegI(env);
          addInstr(env, mk_iMOVsd_RR(r0, tmp));
          addInstr(env, X86Instr_Alu32R(Xalu_OR,rmi1,tmp));
          return Xcc_NZ;
       }
    }
+
    /* CmpNEZ32(x) */
    if (e->tag == Iex_Unop 
        && e->Iex.Unop.op == Iop_CmpNEZ32) {
@@ -1603,6 +1604,24 @@ static X86CondCode iselCondCode_wrk ( ISelEnv* env, IRExpr* e )
       }
    }
 
+   /* CmpNEZ64(Or64(x,y)) */
+   {
+      DECLARE_PATTERN(p_CmpNEZ64_Or64);
+      DEFINE_PATTERN(p_CmpNEZ64_Or64,
+                     unop(Iop_CmpNEZ64, binop(Iop_Or64, bind(0), bind(1))));
+      if (matchIRExpr(&mi, p_CmpNEZ64_Or64, e)) {
+         HReg    hi1, lo1, hi2, lo2;
+         HReg    tmp  = newVRegI(env);
+         iselInt64Expr( &hi1, &lo1, env, mi.bindee[0] );
+         addInstr(env, mk_iMOVsd_RR(hi1, tmp));
+         addInstr(env, X86Instr_Alu32R(Xalu_OR,X86RMI_Reg(lo1),tmp));
+         iselInt64Expr( &hi2, &lo2, env, mi.bindee[1] );
+         addInstr(env, X86Instr_Alu32R(Xalu_OR,X86RMI_Reg(hi2),tmp));
+         addInstr(env, X86Instr_Alu32R(Xalu_OR,X86RMI_Reg(lo2),tmp));
+         return Xcc_NZ;
+      }
+   }
+
    /* CmpNEZ64(x) */
    if (e->tag == Iex_Unop 
        && e->Iex.Unop.op == Iop_CmpNEZ64) {