From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 4 Apr 2023 13:51:07 +0000 (+0200)
Subject: service: rename service_close_socket_fd() → service_release_socket_fd()
X-Git-Tag: v254-rc1~736^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=81a1d6d6790ad6ae8ff63147dfab68e6835178c3;p=thirdparty%2Fsystemd.git

service: rename service_close_socket_fd() → service_release_socket_fd()

Just to match service_release_stdio_fd() and service_release_fd_store()
in the name, since they do similar things.

This follows the concept that we "release" resources, and this is all
generically wrapped in "service_release_resources()".
---

diff --git a/src/core/service.c b/src/core/service.c
index c1669da3a2e..e59c5796276 100644
--- a/src/core/service.c
+++ b/src/core/service.c
@@ -200,7 +200,7 @@ static int service_set_main_pid(Service *s, pid_t pid) {
         return 0;
 }
 
-void service_close_socket_fd(Service *s) {
+void service_release_socket_fd(Service *s) {
         assert(s);
 
         if (s->socket_fd < 0 && !UNIT_ISSET(s->accept_socket) && !s->socket_peer)
@@ -454,8 +454,6 @@ static void service_done(Unit *u) {
         s->usb_function_descriptors = mfree(s->usb_function_descriptors);
         s->usb_function_strings = mfree(s->usb_function_strings);
 
-        service_close_socket_fd(s);
-
         service_stop_watchdog(s);
 
         s->timer_event_source = sd_event_source_disable_unref(s->timer_event_source);
@@ -463,8 +461,9 @@ static void service_done(Unit *u) {
 
         s->bus_name_pid_lookup_slot = sd_bus_slot_unref(s->bus_name_pid_lookup_slot);
 
-        service_release_fd_store(s);
+        service_release_socket_fd(s);
         service_release_stdio_fd(s);
+        service_release_fd_store(s);
 }
 
 static int on_fd_store_io(sd_event_source *e, int fd, uint32_t revents, void *userdata) {
@@ -4974,7 +4973,7 @@ static void service_release_resources(Unit *u) {
 
         log_unit_debug(u, "Releasing resources...");
 
-        service_close_socket_fd(s);
+        service_release_socket_fd(s);
         service_release_stdio_fd(s);
 
         if (s->fd_store_preserve_mode != EXEC_PRESERVE_YES)
diff --git a/src/core/service.h b/src/core/service.h
index 1d1aa91fc6d..5b7f67457e2 100644
--- a/src/core/service.h
+++ b/src/core/service.h
@@ -244,7 +244,7 @@ static inline usec_t service_get_watchdog_usec(Service *s) {
 extern const UnitVTable service_vtable;
 
 int service_set_socket_fd(Service *s, int fd, struct Socket *socket, struct SocketPeer *peer, bool selinux_context_net);
-void service_close_socket_fd(Service *s);
+void service_release_socket_fd(Service *s);
 
 usec_t service_restart_usec_next(Service *s);
 
diff --git a/src/core/socket.c b/src/core/socket.c
index c26daced1ac..891276fd508 100644
--- a/src/core/socket.c
+++ b/src/core/socket.c
@@ -2393,7 +2393,7 @@ static void socket_enter_running(Socket *s, int cfd_in) {
                 if (r < 0) {
                         /* We failed to activate the new service, but it still exists. Let's make sure the
                          * service closes and forgets the connection fd again, immediately. */
-                        service_close_socket_fd(SERVICE(service));
+                        service_release_socket_fd(SERVICE(service));
                         goto fail;
                 }