From: Stefan Metzmacher Date: Fri, 24 Aug 2012 11:17:23 +0000 (+0200) Subject: s4:librpc/rpc: use talloc_zero for 'struct rpc_request' X-Git-Tag: samba-4.0.0beta7~32 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=81bc57d39536516d64fd59978e300d64eac1d97c;p=thirdparty%2Fsamba.git s4:librpc/rpc: use talloc_zero for 'struct rpc_request' metze --- diff --git a/source4/librpc/rpc/dcerpc.c b/source4/librpc/rpc/dcerpc.c index 4cec4b596c7..155150ed97c 100644 --- a/source4/librpc/rpc/dcerpc.c +++ b/source4/librpc/rpc/dcerpc.c @@ -1478,22 +1478,14 @@ static struct rpc_request *dcerpc_request_send(TALLOC_CTX *mem_ctx, p->conn->transport.recv_data = dcerpc_recv_data; - req = talloc(mem_ctx, struct rpc_request); + req = talloc_zero(mem_ctx, struct rpc_request); if (req == NULL) { return NULL; } req->p = p; req->call_id = next_call_id(p->conn); - req->status = NT_STATUS_OK; req->state = RPC_REQUEST_QUEUED; - req->payload = data_blob(NULL, 0); - req->flags = 0; - req->fault_code = 0; - req->ignore_timeout = false; - req->async.callback = NULL; - req->async.private_data = NULL; - req->recv_handler = NULL; if (object != NULL) { req->object = (struct GUID *)talloc_memdup(req, (const void *)object, sizeof(*object)); @@ -1501,8 +1493,6 @@ static struct rpc_request *dcerpc_request_send(TALLOC_CTX *mem_ctx, talloc_free(req); return NULL; } - } else { - req->object = NULL; } req->opnum = opnum;