From: David Hankins <dhankins@isc.org>
Date: Tue, 4 Dec 2007 21:00:39 +0000 (+0000)
Subject: - A reference overleak in DHCPv6 shared network processing was repaired.
X-Git-Tag: v4_0_0rc1~23
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=821f2dda54962846f07005a5ae7bd18422e62ea3;p=thirdparty%2Fdhcp.git

- A reference overleak in DHCPv6 shared network processing was repaired.
  [ISC-Bugs #17337]
---

diff --git a/RELNOTES b/RELNOTES
index 914db2a35..311154db1 100644
--- a/RELNOTES
+++ b/RELNOTES
@@ -88,6 +88,8 @@ suggested fixes to <dhcp-users@isc.org>.
 - A bug was fixed that caused the DHCPv6 ORO option to be corrupted with
   seemingly random values.
 
+- A reference overleak in DHCPv6 shared network processing was repaired.
+
 			Changes since 4.0.0b2
 
 - Clarified error message when lease limit exceeded
diff --git a/server/dhcpv6.c b/server/dhcpv6.c
index ca4a49549..ac59b2848 100644
--- a/server/dhcpv6.c
+++ b/server/dhcpv6.c
@@ -947,7 +947,6 @@ pick_v6_address(struct iaaddr **addr, struct shared_network *shared_network,
 	 * No pools, we're done.
 	 */
 	if (shared_network->ipv6_pools == NULL) {
-		shared_network_dereference(&shared_network, MDL);
 		log_debug("Unable to pick client address: "
 			  "no IPv6 pools on this shared network");
 		return ISC_R_NORESOURCES;
@@ -979,7 +978,6 @@ pick_v6_address(struct iaaddr **addr, struct shared_network *shared_network,
 			}
 			shared_network->last_ipv6_pool = i;
 
-			shared_network_dereference(&shared_network, MDL);
 			log_debug("Picking pool address %s",
 				  inet_ntop(AF_INET6, &((*addr)->addr),
 				  	    tmp_buf, sizeof(tmp_buf)));