From: Stefan Metzmacher <metze@samba.org>
Date: Tue, 11 Jun 2019 15:47:24 +0000 (+0200)
Subject: Revert "libcli/smb: add missing struct smb2_signing_key allocation in smb2cli_session... 
X-Git-Tag: ldb-2.0.5~403
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=824db2967279dd01e7cfd69abf9b848975b5d451;p=thirdparty%2Fsamba.git

Revert "libcli/smb: add missing struct smb2_signing_key allocation in smb2cli_session_set_channel_key()"

This reverts commit 08750166542f46644038d1ff9d839b270436addf.

This was pushed to fast, the corrected commit follows.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/libcli/smb/smbXcli_base.c b/libcli/smb/smbXcli_base.c
index 133b961528b..e916a17e07a 100644
--- a/libcli/smb/smbXcli_base.c
+++ b/libcli/smb/smbXcli_base.c
@@ -6302,15 +6302,6 @@ NTSTATUS smb2cli_session_set_channel_key(struct smbXcli_session *session,
 	memcpy(channel_key, _channel_key.data,
 	       MIN(_channel_key.length, sizeof(channel_key)));
 
-	session->smb2_channel.signing_key = talloc_zero(session,
-						 struct smb2_signing_key);
-	if (session->smb2_channel.signing_key == NULL) {
-		ZERO_STRUCT(channel_key);
-		return NT_STATUS_NO_MEMORY;
-	}
-	talloc_set_destructor(session->smb2_channel.signing_key,
-			      smb2_signing_key_destructor);
-
 	session->smb2_channel.signing_key->blob =
 		data_blob_talloc(session->smb2_channel.signing_key,
 				 channel_key,