From: Roger Dingledine <arma@torproject.org>
Date: Thu, 24 Mar 2016 23:57:39 +0000 (-0400)
Subject: use a clearer argument for connection_ap_make_link()
X-Git-Tag: tor-0.2.8.2-alpha~27^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8251fe515001ee6c8a1c37f080caa3ed167e7798;p=thirdparty%2Ftor.git

use a clearer argument for connection_ap_make_link()

that function calls it argument "want_onehop", so it makes more
sense to pass that boolean into it.
---

diff --git a/src/or/directory.c b/src/or/directory.c
index 023d3f6ace..99091b5100 100644
--- a/src/or/directory.c
+++ b/src/or/directory.c
@@ -1199,9 +1199,7 @@ directory_initiate_command_rend(const tor_addr_port_t *or_addr_port,
                               conn->base_.address, conn->base_.port,
                               digest,
                               SESSION_GROUP_DIRCONN, iso_flags,
-                    /* XXX dirconn_direct is misleading below. we should use
-                     * !anonymized_connection, since that's what we mean. */
-                              use_begindir, conn->dirconn_direct);
+                              use_begindir, !anonymized_connection);
     if (!linked_conn) {
       log_warn(LD_NET,"Making tunnel to dirserver failed.");
       connection_mark_for_close(TO_CONN(conn));