From: Jinjie Ruan <ruanjinjie@huawei.com>
Date: Thu, 27 Jun 2024 07:29:59 +0000 (+0100)
Subject: ARM: 9406/1: Fix callchain_trace() return value
X-Git-Tag: v6.10.4~108
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=825da69656668127f1712d7dc8d19ebcb800ad96;p=thirdparty%2Fkernel%2Fstable.git

ARM: 9406/1: Fix callchain_trace() return value

[ Upstream commit 4e7b4ff2dcaed228cb2fb7bfe720262c98ec1bb9 ]

perf_callchain_store() return 0 on success, -1 otherwise, fix
callchain_trace() to return correct bool value. So walk_stackframe() can
have a chance to stop walking the stack ahead.

Fixes: 70ccc7c0667b ("ARM: 9258/1: stacktrace: Make stack walk callback consistent with generic code")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/arch/arm/kernel/perf_callchain.c b/arch/arm/kernel/perf_callchain.c
index 7147edbe56c67..1d230ac9d0eb5 100644
--- a/arch/arm/kernel/perf_callchain.c
+++ b/arch/arm/kernel/perf_callchain.c
@@ -85,8 +85,7 @@ static bool
 callchain_trace(void *data, unsigned long pc)
 {
 	struct perf_callchain_entry_ctx *entry = data;
-	perf_callchain_store(entry, pc);
-	return true;
+	return perf_callchain_store(entry, pc) == 0;
 }
 
 void