From: Matthijs Mekking <matthijs@isc.org>
Date: Mon, 3 Jun 2024 05:56:21 +0000 (+0200)
Subject: Log error when update fails
X-Git-Tag: v9.20.0~8^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=82635e56d87ca4bacd18ca7debacc71bdef30e74;p=thirdparty%2Fbind9.git

Log error when update fails

The new "too many records" error can make an update fail without the
error being logged. This commit fixes that.
---

diff --git a/lib/ns/update.c b/lib/ns/update.c
index dfecd4262f8..e5e602983b9 100644
--- a/lib/ns/update.c
+++ b/lib/ns/update.c
@@ -3160,9 +3160,18 @@ update_action(void *arg) {
 						dns_diff_clear(&ctx.add_diff);
 						goto failure;
 					}
-					CHECK(update_one_rr(db, ver, &diff,
-							    DNS_DIFFOP_ADD,
-							    name, ttl, &rdata));
+					result = update_one_rr(
+						db, ver, &diff, DNS_DIFFOP_ADD,
+						name, ttl, &rdata);
+					if (result != ISC_R_SUCCESS) {
+						update_log(client, zone,
+							   LOGLEVEL_PROTOCOL,
+							   "adding an RR "
+							   "failed: %s",
+							   isc_result_totext(
+								   result));
+						goto failure;
+					}
 				}
 			}
 		} else if (update_class == dns_rdataclass_any) {