From: Nick Mathewson <nickm@torproject.org>
Date: Mon, 15 Apr 2019 18:52:08 +0000 (-0400)
Subject: Document check for 30176, since it's a bit subtle.
X-Git-Tag: tor-0.4.1.1-alpha~62^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=82a3161c41e2c8d8d800a8c645a93b81bd8b2278;p=thirdparty%2Ftor.git

Document check for 30176, since it's a bit subtle.
---

diff --git a/src/test/test_containers.c b/src/test/test_containers.c
index ad272eeaf5..67ba457975 100644
--- a/src/test/test_containers.c
+++ b/src/test/test_containers.c
@@ -1006,6 +1006,9 @@ test_container_smartlist_remove(void *arg)
   tt_ptr_op(smartlist_get(sl, 1), OP_EQ, &array[2]);
   tt_ptr_op(smartlist_get(sl, 2), OP_EQ, &array[1]);
   tt_ptr_op(smartlist_get(sl, 3), OP_EQ, &array[2]);
+  /* Ordinary code should never look at this pointer; we're doing it here
+   * to make sure that we really cleared the pointer we removed.
+   */
   tt_ptr_op(sl->list[4], OP_EQ, NULL);
 
  done: