From: Andrew Athan <24279435+aathan@users.noreply.github.com>
Date: Sun, 13 Oct 2024 07:22:05 +0000 (-0700)
Subject: Trivial change: Update comments in activate about what running hash -r does (GH-125385)
X-Git-Tag: v3.14.0a1~54
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=82bcaf15890cf85b76b4f62d2dd1710bb49c3ed1;p=thirdparty%2FPython%2Fcpython.git

Trivial change: Update comments in activate about what running hash -r does (GH-125385)

Update comments about what running hash -r does

The old comment said "hash -r" forgets "past commands." However, the documentation for "hash" states that it forgets past locations. The old comment was, in my opinion, confusing. This is because it could be interpreted to mean it does something to the command history (HISTORY/HISTFILE etc) vs the cache of locations.
---

diff --git a/Lib/venv/scripts/common/activate b/Lib/venv/scripts/common/activate
index cbd4873f0122..4593799b7e9b 100644
--- a/Lib/venv/scripts/common/activate
+++ b/Lib/venv/scripts/common/activate
@@ -14,8 +14,9 @@ deactivate () {
         unset _OLD_VIRTUAL_PYTHONHOME
     fi
 
-    # Call hash to forget past commands. Without forgetting
-    # past commands the $PATH changes we made may not be respected
+    # Call hash to forget past locations. Without forgetting
+    # past locations the $PATH changes we made may not be respected.
+    # See "man bash" for more details. hash is usually a builtin of your shell
     hash -r 2> /dev/null
 
     if [ -n "${_OLD_VIRTUAL_PS1:-}" ] ; then