From: Daniel P. Berrangé <berrange@redhat.com>
Date: Wed, 2 Feb 2022 11:43:09 +0000 (+0000)
Subject: conf: validate serial port model in ABI checks
X-Git-Tag: v8.1.0-rc1~206
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=82be0ffe63a1ad32ad582db9644cb83712dda8cb;p=thirdparty%2Flibvirt.git

conf: validate serial port model in ABI checks

The serial port model cannot be allowed to change across migration
as it affects ABI.

Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index e931aef6c4..c8df6dcd4d 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -21094,6 +21094,14 @@ virDomainSerialDefCheckABIStability(virDomainChrDef *src,
         return false;
     }
 
+    if (src->targetModel != dst->targetModel) {
+        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                       _("Target serial model %s does not match source %s"),
+                       virDomainChrSerialTargetModelTypeToString(dst->targetModel),
+                       virDomainChrSerialTargetModelTypeToString(src->targetModel));
+        return false;
+    }
+
     if (src->target.port != dst->target.port) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                        _("Target serial port %d does not match source %d"),