From: Russell Bryant <russell@russellbryant.com>
Date: Tue, 17 Jun 2008 15:48:31 +0000 (+0000)
Subject: Fix a memory leak in astobj2 that was pointed out by seanbright.  When a container
X-Git-Tag: 1.4.22-rc1~205
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=82cf65f89aa376493a8bbf3a72c2e2fae46ce0f3;p=thirdparty%2Fasterisk.git

Fix a memory leak in astobj2 that was pointed out by seanbright.  When a container
got destroyed, the underlying bucket list entry for each object that was in the
container at that time did not get free'd.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@123271 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/main/astobj2.c b/main/astobj2.c
index 7cbf70cce7..bcf34556e6 100644
--- a/main/astobj2.c
+++ b/main/astobj2.c
@@ -599,9 +599,18 @@ static int cd_cb(void *obj, void *arg, int flag)
 static void container_destruct(void *_c)
 {
 	struct ao2_container *c = _c;
+	int i;
 
 	ao2_callback(c, OBJ_UNLINK, cd_cb, NULL);
 
+	for (i = 0; i < c->n_buckets; i++) {
+		struct bucket_list *cur;
+
+		while ((cur = AST_LIST_REMOVE_HEAD(&c->buckets[i], entry))) {
+			ast_free(cur);
+		}
+	}
+
 #ifdef AO2_DEBUG
 	ast_atomic_fetchadd_int(&ao2.total_containers, -1);
 #endif