From: Steve Holme <steve_holme@hotmail.com>
Date: Sun, 11 May 2014 14:03:16 +0000 (+0100)
Subject: sasl: Fixed missing qop in the client's challenge-response message
X-Git-Tag: curl-7_37_0~41
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=8342b6e1dc;p=thirdparty%2Fcurl.git

sasl: Fixed missing qop in the client's challenge-response message

Whilst the qop directive isn't required to be present in a client's
response, as servers should assume a qop of "auth" if it isn't
specified, some may return authentication failure if it is missing.
---

diff --git a/lib/curl_sasl.c b/lib/curl_sasl.c
index d877eff6f7..8a6b522176 100644
--- a/lib/curl_sasl.c
+++ b/lib/curl_sasl.c
@@ -533,9 +533,11 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
 
   /* Generate the response */
   response = aprintf("username=\"%s\",realm=\"%s\",nonce=\"%s\","
-                     "cnonce=\"%s\",nc=\"%s\",digest-uri=\"%s\",response=%s",
+                     "cnonce=\"%s\",nc=\"%s\",digest-uri=\"%s\",response=%s,"
+                     "qop=%s",
                      userp, realm, nonce,
-                     cnonce, nonceCount, uri, resp_hash_hex);
+                     cnonce, nonceCount, uri, resp_hash_hex,
+                     qop);
   if(!response)
     return CURLE_OUT_OF_MEMORY;